Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow producing forward compatible file for fBits value. #15006

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Allow producing forward compatible file for fBits value. #15006

merged 3 commits into from
Mar 25, 2024

Conversation

pcanal
Copy link
Member

@pcanal pcanal commented Mar 18, 2024 •
edited
Loading

Calling file->SetBit(TFile::k630forwardCompatibility); will request to file to store the current value of the bit kIsOnHeap and kNotDeleted for reading in older version that were not setting their value based on the actual state of the read into object.

This fixes #14793

@pcanal pcanal requested a review from jblomer March 18, 2024 21:55
@pcanal pcanal requested a review from dpiparo as a code owner March 18, 2024 21:55
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@pcanal pcanal mentioned this pull request Mar 18, 2024
Closed
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited
Loading

Test Results

    12 files      12 suites   2d 7h 34m 25s ⏱️
 2 603 tests  2 603 ✅ 0 💤 0 ❌
29 185 runs  29 185 ✅ 0 💤 0 ❌

Results for commit 322afd6.

♻️ This comment has been updated with latest results.

ferdymercury
ferdymercury reviewed Mar 20, 2024
View reviewed changes
io/io/inc/TFile.h Outdated Show resolved Hide resolved
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@pcanal
Allow producing forward compatible file for fBits value.
952d173 
Calling `file->SetBit(TFile::k630forwardCompatibility);` will request to file to store the current
value of the bit kIsOnHeap and kNotDeleted for reading in older version that were not setting
their value based on the actual state of the read into object
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@dpiparo
Copy link
Member

dpiparo commented Mar 20, 2024

Thanks a lot @pcanal for this improvement: experiments will appreciate. Given that we still run, with somewhat lower frequency than others, 6.26 builds and tests, would a simple test for 6.26 be of help in roottest?

dpiparo
dpiparo approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. See perhaps my comment about testing the feature in 6.26, with a file maybe written with 6.30 or today's master .

jblomer
jblomer approved these changes Mar 22, 2024
View reviewed changes
io/io/inc/TFile.h Show resolved Hide resolved
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@pcanal pcanal merged commit 8823081 into root-project:master Mar 25, 2024
16 of 17 checks passed
@pcanal pcanal deleted the master-14793 branch March 25, 2024 19:19
@wdconinc wdconinc mentioned this pull request Mar 26, 2024
Merged
7 tasks
wdconinc added a commit to eic/eic-spack that referenced this pull request Mar 26, 2024
@wdconinc
root: add 6.30 forward compatibility fix (#618)
23e83fe 
### Briefly, what does this PR introduce?
This PR adds the ROOT patch for
root-project/root#15006.

### What kind of change does this PR introduce?
- [x] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
@jblomer jblomer mentioned this pull request Jul 2, 2024
Open
1 task
@wdconinc wdconinc mentioned this pull request Aug 7, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferdymercury ferdymercury ferdymercury left review comments

@jblomer jblomer jblomer approved these changes

@dpiparo dpiparo dpiparo approved these changes

Assignees

@pcanal pcanal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6.26 cannot read file written with 6.30.4
5 participants
@pcanal @phsft-bot @dpiparo @jblomer @ferdymercury