Make install improvements #1643
Conversation
|
Can one of the admins verify this patch? |
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ubuntu16/native. |
|
After discussing with @amadio it should be fine to add the proposed flag for JupyROOT, since it is a library only intended to be used internally from the ROOT Jupyter kernel. |
|
Yes, this is probably OK to merge, but I will confirm with @Axel-Naumann first that minicern is not used by external users before removing it from the installation. |
|
Minicern is used, see e.g. https://github.com/cjpl/mdaq-midas/blob/master/roody/Makefile |
|
And maybe @couet can give feedback too, since this is related to hbook/PAW (if I remember correctly) |
|
@Axel-Naumann: That Makefile looks for libminicern.so - and links to it if it is found. It does not link to libminicern.a. The Makefile is backward compatible with old root versions where minicern was a shared library. Now minicern is static and linked into libHbook. Linking to libHbook only is sufficient, and is what the Makefile does when there is no libminicern.so. That Makefile does NOT need libminicern.a. |
|
Hi @ellert, I am a bit reluctant to remove minicern without any notice, but the other two changes should be fine. Even though you are right about the Makefile linked by Axel, I think that since this is a backward incompatible change, we should at least announce the removal in the development release (coming sometime soon), and then remove it only in ROOT 6.14. What do you think? |
ellert
force-pushed
the
make-install-improvements
branch
from
9bd8d4e
to
a582c88
Compare
|
I split off the minicern change to a separate PR #1675. |
|
@phsft-bot build |
|
Starting build on |
|
I see that the build had already passed, so I just merged it. Thanks! |
|
Build failed on slc6/gcc49. |
|
Build failed on ubuntu16/native. Failing tests: |
|
Build failed on slc6/gcc62. Failing tests: |
|
Build failed on slc6/gcc62. Failing tests: |
|
Build failed on ubuntu16/native. Failing tests: |
|
Build failed on centos7/gcc49. Failing tests: |
|
Build failed on mac1013/native. Failing tests: |
Don't install intermediate static libs (mathtext and minicern).
Don't add JupyROOT python extension to cmake exports.