Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix root 9762 on v6-14-00-patches #2929

Merged
merged 5 commits into from
Nov 6, 2018

Conversation

pcanal
Copy link
Member

@pcanal pcanal commented Nov 6, 2018

No description provided.

I.e. insure we do not add or substract from the special offset value kMissing (which result in 'valid'
offset in the 10,000 range leading to memory over-write or out-of-bounds reads)
This addresses part of ROOT-9762
When a rule is associated to the top level node of split collection, we must not add the branch offset,
since the rule is about the content of the collection
@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc48, slc6/gcc62, slc6-i686/gcc49, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON
How to customize builds

@pcanal
Copy link
Member Author

pcanal commented Nov 6, 2018

@phsft-bot build with flags -Dctest_test_exclude_none=on

@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc48, slc6/gcc62, slc6-i686/gcc49, centos7/gcc62, centos7/gcc7, fedora28/native, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dccache=ON -Dctest_test_exclude_none=on
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on fedora28/native.
See console output.

Warnings:

  • /mnt/build/workspace/root-pullrequests-build/root/core/meta/src/TClass.cxx:686:14: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
  • /mnt/build/workspace/root-pullrequests-build/root/net/rootd/src/rootd.cxx:490:14: warning: ‘char* strncat(char*, const char*, size_t)’ accessing between 2147483648 and 2147483647 bytes at offsets 0 and [-2147483647, 2147483648] may overlap 1 byte at offset [0, 4294967295] [-Wrestrict]
  • /mnt/build/workspace/root-pullrequests-build/root/net/rootd/src/rootd.cxx:761:21: warning: ‘%lu’ directive writing between 1 and 20 bytes into a region of size between 0 and 8191 [-Wformat-overflow=]
  • /mnt/build/workspace/root-pullrequests-build/root/net/rpdutils/src/rpdutils.cxx:5203:14: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
  • /mnt/build/workspace/root-pullrequests-build/root/net/rpdutils/src/rpdutils.cxx:4757:26: warning: ‘char* strncpy(char*, const char*, size_t)’ output may be truncated copying 10 bytes from a string of length 10 [-Wstringop-truncation]
  • /mnt/build/workspace/root-pullrequests-build/root/graf3d/ftgl/src/FTVectoriser.cxx:186:76: warning: cast between incompatible function types from ‘void ()(GLenum, FTMesh)’ {aka ‘void ()(unsigned int, FTMesh)’} to ‘GLUTesselatorFunction’ {aka ‘void (*)()’} [-Wcast-function-type]
  • /mnt/build/workspace/root-pullrequests-build/root/graf3d/ftgl/src/FTVectoriser.cxx:187:76: warning: cast between incompatible function types from ‘void ()(void, FTMesh*)’ to ‘GLUTesselatorFunction’ {aka ‘void (*)()’} [-Wcast-function-type]
  • /mnt/build/workspace/root-pullrequests-build/root/graf3d/ftgl/src/FTVectoriser.cxx:188:76: warning: cast between incompatible function types from ‘void ()(FTGL_DOUBLE, void**, GLfloat*, void**, FTMesh*)’ {aka ‘void ()(double, void**, float*, void**, FTMesh*)’} to ‘GLUTesselatorFunction’ {aka ‘void (*)()’} [-Wcast-function-type]
  • /mnt/build/workspace/root-pullrequests-build/root/graf3d/ftgl/src/FTVectoriser.cxx:189:76: warning: cast between incompatible function types from ‘void ()(FTMesh)’ to ‘GLUTesselatorFunction’ {aka ‘void (*)()’} [-Wcast-function-type]
  • /mnt/build/workspace/root-pullrequests-build/root/graf3d/ftgl/src/FTVectoriser.cxx:190:76: warning: cast between incompatible function types from ‘void ()(GLenum, FTMesh)’ {aka ‘void ()(unsigned int, FTMesh)’} to ‘GLUTesselatorFunction’ {aka ‘void (*)()’} [-Wcast-function-type]

And 192 more

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc62.
See console output.

Errors:

Failing tests:

And 41 more

@pcanal
Copy link
Member Author

pcanal commented Nov 6, 2018

all the errors are either pre-existing or related to build system deficiency (missing rebuild)

@pcanal pcanal merged commit 7dab4f5 into root-project:v6-14-00-patches Nov 6, 2018
@pcanal pcanal deleted the v614-ROOT-9762 branch November 6, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants