Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul OptimizeBaskets algorithm. #657

Closed

Conversation

bbockelm
Copy link
Contributor

This is an overhaul of the optimize baskets algorithm, primarily done by Ilija Vukotic and extended by David Smith.

Goal of this algorithm is to minimize overall memory size when writing and number of baskets in a cluster.

Since this work predates ROOT moving to GitHub, it appears the patches primarily are floating around in various people's inbox. This is my attempt to "capture" the knowledge and ideas, even if we don't decide to go this direction.

@pcanal @smithdh

This is an overhaul of the optimize baskets algorithm, primarily done
by Ilija Vukotic and extended by David Smith.

Goal of this algorithm is to minimize overall memory size when writing
and number of baskets in a cluster.
@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@Teemperor
Copy link
Collaborator

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ubuntu14/native.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on mac1012/native.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on centos7/gcc49.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc49.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc62.
See console output.

Failing tests:

@amadio
Copy link
Member

amadio commented Jul 25, 2017

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ubuntu14/native.
See console output.

Failing tests:

@amadio
Copy link
Member

amadio commented Jul 25, 2017

@bbockelm Could you please check the errors reported by Jenkins? The test failure does seem to be caused by the changes in this PR.

@phsft-bot
Copy link
Collaborator

Build failed on mac1012/native.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on centos7/gcc49.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc62.
See console output.

Errors:

  • ERROR: Timeout after 10 minutes
  • ERROR: Error fetching remote repo 'origin'
  • stderr: error: RPC failed; result=18, HTTP code = 200
  • ERROR: Error fetching remote repo 'origin'

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc49.
See console output.

Errors:

  • ERROR: Timeout after 10 minutes
  • ERROR: Error fetching remote repo 'origin'
  • stderr: error: RPC failed; result=18, HTTP code = 200
  • ERROR: Error fetching remote repo 'origin'

Failing tests:

@bbockelm
Copy link
Contributor Author

Closing this PR -- now that it's recorded in GitHub instead of personal email threads, we can revisit at any time in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants