-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul OptimizeBaskets algorithm. #657
Conversation
This is an overhaul of the optimize baskets algorithm, primarily done by Ilija Vukotic and extended by David Smith. Goal of this algorithm is to minimize overall memory size when writing and number of baskets in a cluster.
Can one of the admins verify this patch? |
@phsft-bot build |
Starting build on |
Build failed on ubuntu14/native. Failing tests: |
Build failed on mac1012/native. Failing tests: |
Build failed on centos7/gcc49. Failing tests: |
Build failed on slc6/gcc49. Failing tests: |
Build failed on slc6/gcc62. Failing tests: |
@phsft-bot build |
Starting build on |
Build failed on ubuntu14/native. Failing tests: |
@bbockelm Could you please check the errors reported by Jenkins? The test failure does seem to be caused by the changes in this PR. |
Build failed on mac1012/native. Failing tests: |
Build failed on centos7/gcc49. Failing tests: |
Build failed on slc6/gcc62. Errors:
Failing tests: |
Build failed on slc6/gcc49. Errors:
Failing tests: |
Closing this PR -- now that it's recorded in GitHub instead of personal email threads, we can revisit at any time in the future. |
This is an overhaul of the optimize baskets algorithm, primarily done by Ilija Vukotic and extended by David Smith.
Goal of this algorithm is to minimize overall memory size when writing and number of baskets in a cluster.
Since this work predates ROOT moving to GitHub, it appears the patches primarily are floating around in various people's inbox. This is my attempt to "capture" the knowledge and ideas, even if we don't decide to go this direction.
@pcanal @smithdh