Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VecOps] Use better solution to pick up M_PI on windows #3641

Merged
merged 1 commit into from
Apr 17, 2019
Merged

[VecOps] Use better solution to pick up M_PI on windows #3641

merged 1 commit into from
Apr 17, 2019

Conversation

stwunsch
Copy link
Contributor

@stwunsch stwunsch commented Apr 4, 2019 •
edited
Loading

Many thanks to @bellenot !
Let's check whether the PR builds are happy with this.

Remaining issue with this: Is it ok to include math.h or cmath (or even both?) based on the platform? Could this interfere with picking up the overloads for the fast math functions since math.h and cmath define their API in different namespaces?

@lmoneta You have insights into this? The PR works but still, I feel a little uncomfortable since I do not fully understand the impact of the different includes.

@stwunsch stwunsch self-assigned this Apr 4, 2019
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/default
How to customize builds

bellenot
bellenot reviewed Apr 4, 2019
View reviewed changes
math/vecops/CMakeLists.txt Outdated Show resolved Hide resolved
math/vecops/inc/ROOT/RVec.hxx
#include <math.h>
#else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping both #include <cmath> and #include <math.h> should not hurt (I think)

@stwunsch
Copy link
Contributor Author

stwunsch commented Apr 4, 2019

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on mac1014/cxx17.
See console output.

Warnings:

  • include/ROOT/TTreeReaderFast.hxx:50:16: warning: private field 'fTotCount' is not used [-Wunused-private-field]
  • include/ROOT/TTreeReaderFast.hxx:50:16: warning: private field 'fTotCount' is not used [-Wunused-private-field]
  • include/ROOT/TTreeReaderFast.hxx:50:16: warning: private field 'fTotCount' is not used [-Wunused-private-field]
  • include/ROOT/TTreeReaderFast.hxx:50:16: warning: private field 'fTotCount' is not used [-Wunused-private-field]
  • include/ROOT/TTreeReaderFast.hxx:50:16: warning: private field 'fTotCount' is not used [-Wunused-private-field]
  • include/ROOT/TTreeReaderFast.hxx:50:16: warning: private field 'fTotCount' is not used [-Wunused-private-field]
  • include/ROOT/TTreeReaderFast.hxx:50:16: warning: private field 'fTotCount' is not used [-Wunused-private-field]

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on windows10/default.
See console output.

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora27/noimt.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu18.04-i386/cxx14.
See console output.

Errors:

  • /mnt/build/workspace/root-pullrequests-build/build/include/VecCore/Backend/Vc.h:21:19: error: ‘VcScalarT’ does not name a type
  • /mnt/build/workspace/root-pullrequests-build/build/include/VecCore/Backend/Vc.h:22:19: error: ‘VcScalar’ does not name a type

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu18.04-i386/cxx14.
See console output.

Warnings:

  • /mnt/build/workspace/root-pullrequests-build/root/tree/tree/test/BulkApiVarLength.cxx:102:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘std::size_t {aka unsigned int}’ [-Wformat=]
  • /mnt/build/workspace/root-pullrequests-build/root/tree/tree/test/BulkApiVarLength.cxx:109:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘std::size_t {aka unsigned int}’ [-Wformat=]

Failing tests:

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu18.04-i386/cxx14.
See console output.

Warnings:

  • /mnt/build/workspace/root-pullrequests-build/root/tree/tree/test/BulkApiVarLength.cxx:102:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘std::size_t {aka unsigned int}’ [-Wformat=]
  • /mnt/build/workspace/root-pullrequests-build/root/tree/tree/test/BulkApiVarLength.cxx:109:19: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘std::size_t {aka unsigned int}’ [-Wformat=]

Failing tests:

@stwunsch stwunsch requested a review from lmoneta April 15, 2019 08:38
@stwunsch stwunsch merged commit b800b63 into root-project:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellenot bellenot bellenot left review comments

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

@lmoneta lmoneta Awaiting requested review from lmoneta

Assignees

@stwunsch stwunsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stwunsch @phsft-bot @bellenot