Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a modulemap for libc #477

Merged
merged 1 commit into from
Apr 4, 2017
Merged

Added a modulemap for libc #477

merged 1 commit into from
Apr 4, 2017

Conversation

Teemperor
Copy link
Collaborator

The Linux builds with enabled modules were failing because stdio.h
wasn't provided by a module but textually included. This seemed to
cause merging issues which caused the compilation to fail.

This patch adds a modulemap for a few libc modules that seem to work
without modification as modules inside ROOT.

We had to remove a few 'extern "C"' because importing a module
inside such a context isn't allowed.

@vgvassilev
Copy link
Member

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Dall=On

@phsft-bot
Copy link
Collaborator

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native

@phsft-bot
Copy link
Collaborator

Starting build on slc6/clang_gcc62 and CMake flags -Dccache=ON -Dimt=OFF -Dcxxmodules=On -Dall=On

@phsft-bot
Copy link
Collaborator

Starting build on slc6/clang_gcc62 and CMake flags -Dccache=ON -Dimt=OFF -Dcxxmodules=On -Dall=On

@vgvassilev vgvassilev self-assigned this Apr 4, 2017
@Teemperor Teemperor force-pushed the AddLibCModulemap branch 2 times, most recently from e16f82e to 71a0c45 Compare April 4, 2017 08:23
@martinmine
Copy link
Contributor

@phsft-bot build!

@phsft-bot
Copy link
Collaborator

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native

@vgvassilev
Copy link
Member

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Dall=On

1 similar comment
@martinmine
Copy link
Contributor

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Dall=On

@phsft-bot
Copy link
Collaborator

Starting build on slc6/clang_gcc62 and CMake flags -Dccache=ON -Dimt=OFF -Dcxxmodules=On -Dall=On

@Teemperor
Added modulemap for libc.
513cd66 
The Linux builds with enabled modules were failing because stdio.h
wasn't provided by a module but textually included. This seemed to
cause merging issues which caused the compilation to fail.

This patch adds a modulemap for a few libc modules that seem to work
without modification as modules inside ROOT.

We had to remove a few 'extern "C"' because importing a module
inside such a context isn't allowed.
@phsft-bot
Copy link
Collaborator

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native and CMake flags -Dccache=ON -Dimt=OFF

@vgvassilev
Copy link
Member

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Dall=On

@phsft-bot
Copy link
Collaborator

Starting build on slc6/clang_gcc62 and CMake flags -Dccache=ON -Dimt=OFF -Dcxxmodules=On -Dall=On

@vgvassilev vgvassilev merged commit d6c42b6 into root-project:master Apr 4, 2017
@Teemperor Teemperor deleted the AddLibCModulemap branch April 4, 2017 13:49
This was referenced Nov 17, 2017
Closed
Closed
Merged
Closed
Closed
Merged
@phsft-bot phsft-bot mentioned this pull request Jul 4, 2019
Merged
@phsft-bot phsft-bot mentioned this pull request Jul 6, 2022
Closed
@phsft-bot phsft-bot mentioned this pull request Jul 15, 2022
Closed
@phsft-bot phsft-bot mentioned this pull request May 15, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vgvassilev vgvassilev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Teemperor @vgvassilev @phsft-bot @martinmine