Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support undoing of #undef preprocessor tokens. #645

Merged
merged 4 commits into from
Jul 15, 2017

Conversation

marsupial
Copy link
Contributor

Updates DeclCollectorPPAdapter to new clang interface that reports an when every #undef encountered.

@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@marsupial marsupial force-pushed the PR/0 branch 2 times, most recently from 95f3623 to 83883a1 Compare June 15, 2017 23:58
@marsupial
Copy link
Contributor Author

Ping.

No need for these details to be public.
@marsupial
Copy link
Contributor Author

Ping.

@vgvassilev
Copy link
Member

@phsft-bot build!

@Teemperor, you've been working in this area, could you review?

@marsupial, sorry for the delay. This LGTM.

@phsft-bot
Copy link
Collaborator

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc62.
See console output.

Errors:

  • ninja: error: loading 'build.ninja': No such file or directory

Copy link
Collaborator

@Teemperor Teemperor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Jenkins failed due to infrastructure problems on this node

@vgvassilev
Copy link
Member

@phsft-bot build!

@phsft-bot
Copy link
Collaborator

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@vgvassilev
Copy link
Member

Another infrastructure issue for one of the builds, all rest seem good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants