Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cxxmodules]Restoring back compilation of runtime cxxmodules build after af5a2b4f… #1861

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

oshadura
Copy link
Contributor

@oshadura oshadura commented Apr 16, 2018

…338974e4f0763a66506bbc54fe80e3cb
Failure in CDash:

In file included from input_line_13:8:
/.../build/include/ROOT/TProcessExecutor.hxx:19:10: remark: building module 'Tree' as '/.../build/lib/Tree.pcm' [-Rmodule-build]
#include "TChain.h"
         ^

Error: Had to build non-system module Tree implicitly. You first need to

generate the dictionary for Tree or mark the C++ module as a system
module if you provided your own system modulemap file:
Tree [system] { ... }

@oshadura oshadura requested a review from gganis as a code owner April 16, 2018 13:11
@phsft-bot
Copy link
Collaborator

Starting build on centos7/gcc49, mac1013/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu16/native, ubuntu16/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@oshadura
Copy link
Contributor Author

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

@phsft-bot
Copy link
Collaborator

Starting build on slc6/clang_gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dcxxmodules=On -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@oshadura oshadura changed the title Restoring back compilation of runtime cxxmodules build after af5a2b4f… [cxxmodules]Restoring back compilation of runtime cxxmodules build after af5a2b4f… Apr 16, 2018
@phsft-bot
Copy link
Collaborator

Build failed on slc6/clang_gcc62.
See console output.

Errors:

  • 333/1709 Test Fix leading whitespace CMake error. #219: tutorial-dataframe-tdf002_dataModel ...............................................................***Failed Error regular expression found in output. Regex=[: error:] 10.55 sec
  • 340/1709 Test Add new mathjax tarball for doc. Version 2.6.1 #230: tutorial-dataframe-tdf013_InspectAnalysis .........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.29 sec
  • 344/1709 Test Additional improvements on TRatioPlot #234: tutorial-dataframe-tdf017_vecOpsHEP ...............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.33 sec
  • 594/1709 Test Fixes for 5 coverity defect reports #495: tutorial-math-quasirandom .........................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.26 sec
  • 620/1709 Test Coverity fixes 82576, 82575, 68746, 68745, 68856, 61279, 61577 #526: tutorial-multicore-mtbb201_parallelHistoFill ......................................................***Failed Error regular expression found in output. Regex=[: error:] 5.38 sec
  • 737/1709 Test Support undoing of #undef preprocessor tokens. #645: tutorial-roostats-Zbi_Zgamma ......................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.63 sec
  • 749/1709 Test Overhaul OptimizeBaskets algorithm. #657: tutorial-roostats-rs_numbercountingutils ..........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.72 sec
  • 831/1709 Test LZ4 as a default compression algorithm #750: tutorial-dataframe-tdf002_dataModel-py ............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.44 sec

Warnings:

  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/net/http/civetweb/civetweb.c:2701:8: warning: implicit declaration of function 'pthread_setname_np' is invalid in C99 [-Wimplicit-function-declaration]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/tree/treeplayer/src/TArrowDS.cxx:315:30: warning: lambda capture 'table' is not used [-Wunused-lambda-capture]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/geom/gdml/src/TGDMLWrite.cxx:1996:18: warning: explicitly assigning value of variable of type 'TString' to itself [-Wself-assign]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/test/vmatrix.cxx:583:6: warning: explicitly assigning value of variable of type 'TMatrixD' (aka 'TMatrixT<double>') to itself [-Wself-assign]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/test/vmatrix.cxx:604:6: warning: explicitly assigning value of variable of type 'TMatrixD' (aka 'TMatrixT<double>') to itself [-Wself-assign]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/test/stressLinear.cxx:810:6: warning: explicitly assigning value of variable of type 'TMatrixD' (aka 'TMatrixT<double>') to itself [-Wself-assign]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/test/stressLinear.cxx:831:6: warning: explicitly assigning value of variable of type 'TMatrixD' (aka 'TMatrixT<double>') to itself [-Wself-assign]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/test/stressLinear.cxx:2592:6: warning: explicitly assigning value of variable of type 'TMatrixDSparse' (aka 'TMatrixTSparse<double>') to itself [-Wself-assign]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/test/stressLinear.cxx:2610:6: warning: explicitly assigning value of variable of type 'TMatrixDSparse' (aka 'TMatrixTSparse<double>') to itself [-Wself-assign]
  • /mnt/build/jenkins/workspace/root-pullrequests-build/root/test/stressLinear.cxx:3447:6: warning: explicitly assigning value of variable of type 'TVectorD' (aka 'TVectorT<double>') to itself [-Wself-assign]

And 4 more

Failing tests:

And 25 more

@gganis
Copy link
Member

gganis commented Apr 16, 2018

Thanks you for providing the patch.
The proposed change looks OK to me (removal of those two header files).
The test failures do not seem related to this patch.
I'll make a few additional cross checks and then I'll merge.

@gganis
Copy link
Member

gganis commented Apr 17, 2018

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on centos7/gcc49, mac1013/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu16/native, ubuntu16/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

Copy link
Member

@gganis gganis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is ok with me.
I will merge it asap.

@gganis gganis merged commit 6f057db into root-project:master Apr 17, 2018
@gganis
Copy link
Member

gganis commented Apr 17, 2018

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants