[RF] Improving the interface to the batch mode in RooAbsPdf::fitTo and RooAbsPdf::createNLL
#9420
Conversation
The code that was previously in RooAbsPdf.cxx got moved to a new file BatchModeHelpers.cxx. Furthermore, code duplication in retrieving the configuration parameters is removed.
This makes the old batch mode interface available again in
`RooAbsPdf::fitTo` and `RooAbsPdf::createNLL`. It is not for the user,
but the developer to easily make performance comparisons. One just has
to pass the command argument `RooFit::BatchMode("old")`.
The enum class `RooBatchCompute::BatchMode` was also moved to
`RooFit::BatchModeOption` because it was never used int the batch
computation library. The `Option` was added to the name to avoid a
naming collision with the `RooFit::BatchMode` command argument.
guitargeek
requested review from
bellenot,
hageboeck and
lmoneta
as code owners
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/default. Failing tests: |
|
Build failed on ROOT-ubuntu2004/soversion. Failing tests: |
|
Build failed on mac11/cxx17. Failing tests: |
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests: |
|
Build failed on mac1015/python3. Failing tests: |
|
Build failed on windows10/cxx14. Failing tests: |
Before, and exact foating point match was required in the LikelihoodSerialTest.BatchedUnbinnedGaussianND unit test. However, the results of the new batch mode can be slightly different numerically, so we introduce a relative tolerance of 1e-14 when comparing the NLL from the new likelihood classes to the batch mode NLL.
|
Starting build on |
This is a follow-up to #9004.
Further description can be found in the commit messages.