[RF] New RooFit batch mode with GPU support #9004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
roofit_batchmode_dev
branch
3 times, most recently
from
1bb15dc
to
e002db0
Compare
guitargeek
force-pushed
the
roofit_batchmode_dev
branch
3 times, most recently
from
8339ed0
to
eb20234
Compare
The new RooFitDriver now also prints some info which is fine, so we can't just expect the mesagge log to be empty if all RooAbsArgs are implemented in the batch mode.
* implment `RooAbsCachedPdf::computeBatch` * consistently recompute cached normalization integral in RooAbsPdf if parameters change * unrelated: compute only value servers in `RooFitDriver`
There is also a new helper class `RooFitDriver::Dataset` to manage the necessary information from the dataset that is used for the fit.
This is to support RooFit pdfs that use the category index for value computations, such as `RooEfficiency`.
It was not such a good idea to write to standard output every time a computation library is loaded. This is quite verbose and some unit tests fail because of the unexpected output. This commit makes the RooFitDriver write about the loaded computation libraries in its constructor, but only if the `FastEvaluations` message topic is switched on at the Info level (not the case by default).
Some tests still fail with this implementation, we will rely on the fallback mode until a solution is found.
This makes it easier to also handle different buffer sizes later on, as required by the RooSimulaneous fits.
With the `fast` flag enabled in `RooDataHist::calcTreeIndex`, the caller promises that layout of `coords` is identical to our internal `vars`. Previously, this was verified with an assert in debug mode like this: assert(!fast || coords.hasSameLayout(_vars)); However, there are usecases where the externally provided `coords` have different names than the internal variables, even though they correspond to each other. For example, if the observables in the computation graph are renamed with `redirectServers`, which happens in a RooSimultaneous fit with the new RooFit batch mode. Hence, we can't do a meaningful assert here.
This excludes the pdfs that are implemented in the BatchComputation library directy, for which we have to find a solution later. The problem is that in CUDA evaluations, the division by the normalization is done on the device, but we have not implemented division with NaN packing in CUDA yet. However, we support now NaN-packing for all pdfs that don't have a `computeBatch` function implemented. In particular, this makes the `testNaNPacker` pass (it involves a RooGenericPdf).
The `DISABLED_IntegrateBins_SubRange` test covers the minimization of a `RooBinSamplingPdf` in a sub-range. This test does not work with the new RooFit batch mode yet, and there was no time to fix this issue before the ROOT v6.26 branch point.
guitargeek
force-pushed
the
roofit_batchmode_dev
branch
from
2b7bfd8
to
93a3aba
Compare
|
Starting build on |
guitargeek
dismissed
Axel-Naumann’s stale review
REquests have been addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description will follow, for now let's see what the CI is doing.
Corresponding roottest PR: root-project/roottest#778,