-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/deploy heroku button #31
Conversation
also noting - the 'official' deployment (https://dogstack.herokuapp.com/) of this example app is out of date, once this PR is good then we should update that deployment too. |
], | ||
"env": { | ||
"APP_URL": { | ||
"description": "the url that the app is running at (if you are deploying from the README, replace [app name] below with the app name you chose above)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iainkirkpatrick It’s not clear what was called “[app name] above”
I’d also suggest adding some simple instructions to the reader file by the button stepping a new user through getting an app name and editing this app.json file before clicking the button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agentlewis do you mean “with the app name you chose above” is unclear? That refers to the form you get taken to when you click the button - is it unclear in the context of that form?
The user shouldn’t have to edit anything before clicking the button - when they click and get to the form, they just make up a name for their app
Or am I misunderstanding you maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry I didnt understand that the button took you to a form. I get it now.
Maybe just say the heroku app name. “Above” made me feel I missed something.
puts a 'deploy to heroku' button into the README, so that when the repo is cloned / forked to start a new project, a user can immediately deploy a live version to heroku
refer to root-systems/dogstack#87
please squash commits as many were experimental 😅