Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iso-Area underestimates distance if line verticies are sparse #16

Closed
josephholler opened this issue May 30, 2019 · 1 comment
Closed
Labels
wontfix This will not be worked on

Comments

@josephholler
Copy link

josephholler commented May 30, 2019

In order to get more accurate Iso-Area results, users may need to densify their Network Layer input using the Densify by interval algorithm.

I tested the algorithm by constructing a few very long lines with few vertices and calculating Iso-Areas at intervals that would fall in between distant vertices. Since the algorithm first calculates a point cloud using all the vertices in the network and does not create any new points , it means that the outer-most iso-area contour or polygon may underestimate cost by as much as the longest segment of a line.

Most network inputs will already have reasonably dense vertices: this is only a problem if you have some very long, straight line segments.

E.g. see below, the 2500m Iso-Area point cloud and interpolation originating at the red hospital icon:
image

and the same result after using Densify network:
image
(I'm not sure what happened to the interpolation at the southern end of this figure... there are rows of nodata, but nonetheless you can see the difference in the point cloud)

@root676
Copy link
Owner

root676 commented Aug 14, 2019

Thank you for pointing this out - I will still mark this as wontfix because it is the users responsibility to prepare his/her datasets in a reasonable manner (in the same way as with adding reasonable cost values or oneway information). This case is certainly not a common one and therefore has to be preprocessed by the user. Furthermore, adding the parameters for a user side densification would result in unnecessarily complex algorithm input UIs (...and they are already pretty complex).

@root676 root676 closed this as completed Aug 14, 2019
@root676 root676 added the wontfix This will not be worked on label Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants