Skip to content

Commit

Permalink
Improve TODO detail
Browse files Browse the repository at this point in the history
  • Loading branch information
pwaller committed Apr 7, 2013
1 parent 705f890 commit 502b31d
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions weboot/resources/actions.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,21 @@ def p(self, parent, key, param, value):
"""
Store a parameter
(BUG)
Note: This does not cause the action to enter the traversal hierarchy
TODO(pwaller)
We want to support /!p/logy/1/, for example, to set options through the
URL. This could allow /!p/logy/0,1/ to create a multitraverser
with both types of plots.
The current technique doesn't work, because:
This does not cause the action to enter the traversal hierarchy
because `from_parent` isn't used. What is needed is a way to create
a copy of `self` which can be placed correctly into the hierarchy.
(pwaller) doesn't currently know how to achieve this reliably.
It's possible we can achieve this by making a special resource which
wraps `self` but knows its place in the heirarchy.
"""
self.request.params.multi.dicts += ({param: value},)
return self
Expand Down

0 comments on commit 502b31d

Please sign in to comment.