Make Acorn work with Mix's manifest #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. This ends up being problematic as the slash is stripped in scenarios where the asset you're targeting isn't inside of the Manifest.. To be honest, I'm not entirely sure how you want to handle this in the long-run @QWp6t – I know the todo's mention you reworking the Manifest/Asset classes a bit. Otherwise, when returning the URI I'd need to check for a slash otherwise adding one so non-versioned assets would still ultimately return the proper URL. |
Adds registration to Acorn application; calls from bootstrap. With this change configurable service providers are successfully registered and booted based on the `providers` inventory in `config/app.php`. closes #14
Fix failing tests Add test for manifest path and URI with query string Change main.js/css to app.js/css in tests Add missing trailing space to ! in conditionals (PSR-1)
|
Alright.
Can't say I'm 100% happy with the Still cleaner than Laravel's official |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Mix's manifest which requires the path to be prepended with
/.When fetching the local path, I made use of
Str::before()to strip?id=Xthus making it functional with Mix's built in.version()as well as plugins such as laravel-mix-versionhash which handle hashing via the filename instead of a query string.