Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Discovery Continued #20

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Package Discovery Continued #20

merged 2 commits into from
Jun 13, 2019

Conversation

Log1x
Copy link
Sponsor Member

@Log1x Log1x commented Jun 13, 2019

  • Add ComposerScripts class to handle Composer events for package discovery
  • Move console commands to their own folder
  • Add package:clear command
  • Add optimize command
  • Add optimize:clear command
  • Remove unused use statement in Bindings

Related: roots/sage#2201

…very

Move console commands to their own folder
Add package:clear command
Add optimize command
Add optimize:clear command
Remove unused use statement in Bindings
@Log1x Log1x requested a review from QWp6t June 13, 2019 10:51
@QWp6t QWp6t merged commit 1f3386d into master Jun 13, 2019
@QWp6t QWp6t deleted the log1x/patch-1 branch June 13, 2019 15:10
@QWp6t
Copy link
Sponsor Member

QWp6t commented Jun 13, 2019

At some point we should look into refactoring ComposerScripts to first attempt to use wp-cli and only fallback to current implementation on failure. That would be cleaner since it wouldn't make any assumptions about Acorn basepath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants