Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Check that .blade.php cannot be accessed remotely #21

Closed
wants to merge 1 commit into from

Conversation

QWp6t
Copy link
Sponsor Member

@QWp6t QWp6t commented Jun 18, 2019

Should this be cached, or should it be a manual check via wp-cli? Should this throw an error or show a more polite notification/alert? What sort of options/filters should be implemented?

Should we instead put this on the ViewServiceProvider and iterate over all view paths within the document root and select an actual .blade.php from each path to ensure all paths are protected?

Not sure how crazy we want to get with this. I'm personally of the mindset that this is outside the scope of Sage and Acorn, and I'd be in favor of completely removing it. But if we do want it, my preference would be to implement it as a wp-cli command.

@QWp6t QWp6t closed this Jul 8, 2019
@QWp6t QWp6t deleted the blade-check-preflight branch July 8, 2019 14:09
@QWp6t
Copy link
Sponsor Member Author

QWp6t commented Jul 8, 2019

I think we're going to create some sort of plugin that adds a site health check instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant