Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃懡 Enable $_SERVER['HTTPS'] in console #215

Merged
merged 1 commit into from Mar 27, 2022
Merged

馃懡 Enable $_SERVER['HTTPS'] in console #215

merged 1 commit into from Mar 27, 2022

Conversation

QWp6t
Copy link
Sponsor Member

@QWp6t QWp6t commented Mar 27, 2022

Oftentimes developers will use WordPress functions to set Acorn config values, including values that reference URLs such as assets public path or disks. When running wp acorn optimize, this can result in undesirable outcomes if the developer has not manually set $_SERVER['HTTPS'] during cli.

This PR enables $_SERVER['HTTPS'] in a console environment when the home URL's scheme is HTTPS.

Developers can override this via acorn/enable_https_in_console filter.

@QWp6t QWp6t merged commit f294ca3 into 2.x Mar 27, 2022
@QWp6t QWp6t deleted the https-in-console branch March 27, 2022 17:19
QWp6t added a commit that referenced this pull request Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant