Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit property 'protected Filesystem ' to remove deprecated … #286

Merged
merged 3 commits into from May 4, 2023

Conversation

sammyhayman
Copy link
Contributor

…notice in Sage class.

This should fix the "Creation of dynamic property Roots\Acorn\Sage\Sage::$files is deprecated" notice.

Copy link
Sponsor Member

@QWp6t QWp6t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! 🙏🏼

Just a small change that I'm requesting and we'll be good to merge. 🙂

src/Roots/Acorn/Sage/Sage.php Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@QWp6t QWp6t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this looks great! Thanks again! 🙏

src/Roots/Acorn/Sage/Sage.php Outdated Show resolved Hide resolved
@QWp6t QWp6t merged commit 79eb9b0 into roots:main May 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants