-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Bootloader: Bail early on wp-login.php
/wp-admin
, and some other /wp-
requests
#339
Conversation
wp-login.php
/wp-admin
, and some other /wp-
requests
Thanks for starting a fix so quickly. I also noticed that there were problems with REST queries in the block editor. But I'm not sure if it's just the cookie not being set. |
Pushed an update that should fix those I think? If not, do you mind showing which requests are failing for you still? I've tested on:
|
@retlehs Worked for me! Thank you 馃挭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@dr5hn Does |
@retlehs Yes it return the hidden admin path url. When i make this change, login works! diff --git a/src/Roots/Acorn/Bootloader.php b/src/Roots/Acorn/Bootloader.php
index fc0e8c9..b57adfc 100644
--- a/src/Roots/Acorn/Bootloader.php
+++ b/src/Roots/Acorn/Bootloader.php
@@ -266,6 +266,7 @@ class Bootloader
'/wp-login.php',
'/wp-signup.php',
'/wp-admin/',
+ '/secret/'
])) {
return; // Let WordPress handle these requests
} Adding this dynamic path will get this working parse_url(wp_login_url(), PHP_URL_PATH), |
Fix #337