Update Laravel components to 5.8.x #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Application now implements Illuminate\Support\Contracts\Application * Laravel Application interface implementation has been isolated to a trait for maintenance purposes * Bootstrap classes are now used during Application boot * Globals are optionally enabled using a WordPress filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't quite working yet. There were a few minor changes that were needed to get it working. I'll push those commits soon.
Acorn\Concerns\Application.php will probably poop itself if you play with it too much. The broken stuff won't be used out of the box by Sage or Clover, so I'm not terribly concerned about it, but I plan to refactor it before Acorn 1.0.
app()->withAliases())I'll tag a release of Acorn once I've tested these updates some more.