Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with bedrock_autoloader option #386

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@slackday
Copy link
Contributor

@slackday slackday commented Oct 5, 2018

This fixes an issue where the bedrock_autoloader option is set but the number of plugins differs. I ran into this issue when moving a plugin from plugin to mu-plugin and deploying to a remote server.

I haven't been able to recreate this in a reliable way but having ran into this issue a couple of times on different servers I figured I'd propose my fix.

Basically $cache will not evaluate to false because it will be set to an array looking like this:

array(
'plugins' => array(),
'count' => 0,
);

This fixed it for me.

I created the issue in the wrong project. And instead of spamming new issue here you can read my original issue on the Trellis-project roots/trellis#1022.

If you want me to open issue here anyway I can do it.

@swalkinshaw
Copy link
Member

@swalkinshaw swalkinshaw commented Oct 5, 2018

This seems to make sense. We'll have to try it out first.

@slackday slackday changed the title Fix issue when bedrock_autoloader option Fix issue with bedrock_autoloader option Oct 5, 2018
@swalkinshaw swalkinshaw merged commit 31eea38 into roots:master Mar 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants