Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump requirements to PHP 7.1 #405

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Bump requirements to PHP 7.1 #405

merged 2 commits into from
Dec 20, 2018

Conversation

retlehs
Copy link
Sponsor Member

@retlehs retlehs commented Dec 19, 2018

@retlehs retlehs changed the title Require PHP 7.1 Bump requirements to PHP 7.1 Dec 19, 2018
@retlehs retlehs merged commit c0f98d7 into master Dec 20, 2018
@retlehs retlehs deleted the require-php-7.1 branch December 20, 2018 00:52
@drzraf
Copy link

drzraf commented Jan 9, 2019

While I understand the reasoning and votes behind this merge, I think its a bad decision.

Debian, for the first time in its history does not provide a version of PHP supported by upstream. But, by definition, provides (security) support for the software bundled (PHP being one of them).

For that reason, even if upstream dropped support <7.1 I believe distribution must be fairly considered too.
Debian does support PHP 7.0, but none of the above version are available in Debian stable.

Since almost no one run PHP binary outside a Linux distribution I believe the PHP requirement should be set to >= 7.0 until this version get obsoleted (not as in "upstream speech" but as in "people uses and server boxes")

I also think it's bad use of composer require which is not intended for politics about what people install on their servers but rather only which dependencies and versions **this** software needs to run correctly

@swalkinshaw
Copy link
Member

@drzraf fair points. However, Bedrock is still a boilerplate basically. It's intended to be customized as you need. It's also not a framework you upgrade in the traditional sense. So for anyone who used an older version of Bedrock as a starting point, this wouldn't affect them.

And if you're starting a new project on an OS which doesn't provide 7.1 (like Debian), you can either use a slightly older version or just manually edit composer.json.

We still believe this is a sensible default to have considering how Bedrock is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants