Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vlucas/phpdotenv to ^3 #412

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
4 participants
@knowler
Copy link
Member

knowler commented Jan 28, 2019

Resolves #411

For compatibility with ACF Pro Installer, I made a PR to bump the version requirement over there as well: PhilippBaschke/acf-pro-installer#35

@tristanbes

This comment has been minimized.

Copy link
Contributor

tristanbes commented Jan 29, 2019

Thank you 👍

@austinpray
Copy link
Member

austinpray left a comment

Haven't tested this but I'm definitely a fan of this v3 feature vlucas/phpdotenv#311. Worth upgrading 👍

@austinpray

This comment has been minimized.

Copy link
Member

austinpray commented Feb 6, 2019

Works for me, @tristanbes did you try this out too?

@tristanbes

This comment has been minimized.

Copy link
Contributor

tristanbes commented Feb 6, 2019

Not yet, but tomorrow someone will test this on my team :). Given the small changes it requires, I don't see any reason not to work 👍

@retlehs retlehs merged commit ad849ef into master Feb 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@retlehs retlehs deleted the update-phpdotenv branch Feb 7, 2019

@tristanbes

This comment has been minimized.

Copy link
Contributor

tristanbes commented Feb 7, 2019

Forgot to mention but yes, tests were ok on our side too.

MWDelaney added a commit to MWDelaney/acf-pro-installer that referenced this pull request Feb 11, 2019

Update phpdotenv constraint
Allows for use on Bedrock post-roots/bedrock#412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.