Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect HTTPS if wordpress is behind a reverse proxy #413

Merged
merged 4 commits into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@tristanbes
Copy link
Contributor

tristanbes commented Jan 30, 2019

Hello,

It'd be great if HTTPS would be working behind a reverse proxy, which is very common when using a PaaS or a WAF, or any decent cloud providers.

https://codex.wordpress.org/Function_Reference/is_ssl#Notes

Since it's a condition, it does not harm existing wordpress installations.

Detect HTTPS if wordpress is behind a reverse proxy
Hello,

It'd be great if HTTPS would be working behind a reverse proxy, which is very common when using a PaaS or a WAF, or any decent cloud providers.

https://codex.wordpress.org/Function_Reference/is_ssl#Notes

Since it's a condition, it does not harm existing wordpress installations.
@swalkinshaw

This comment has been minimized.

Copy link
Member

swalkinshaw commented Jan 31, 2019

Seems like a good thing to support by default 👍

Maybe this should go above loading the env specific config? It would allow them have logic based on this.

Show resolved Hide resolved config/application.php Outdated
@tristanbes

This comment has been minimized.

Copy link
Contributor Author

tristanbes commented Jan 31, 2019

@swalkinshaw done.

Show resolved Hide resolved config/application.php Outdated
Show resolved Hide resolved config/application.php Outdated
Update config/application.php
Co-Authored-By: tristanbes <tristan@yproximite.com>

@swalkinshaw swalkinshaw merged commit 785c64f into roots:master Feb 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@swalkinshaw

This comment has been minimized.

Copy link
Member

swalkinshaw commented Feb 2, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.