Make DSN implementation more uniform

[Log1x]

Figured I'd propose this change as the implementation is still early so despite being a "breaking change" – very few would be affected.

• Change DATABASE_URL to DB_URL to remain uniform with the other database variables
• Improve phrasing on the README and .env.example DocBlock
• Minor golfing / cleanup on how the DSN is handled in application.php
• Apparently editorconfig found some trailing whitespace in the README 🙀

[swalkinshaw]

While DB_URL is more consistent with the other constants, DATABASE_URL is actually kind of standard. Lots of hosting platforms use that name specifically and some other web frameworks have it integrated as well.

All the other changes look good though 👍

[Log1x]

Want to wait for more feedback or should I change it?

Drupal (lol) uses DB_URL – Laravel, etc. doesn't use DSN which isn't a surprise, it isn't user-friendly and there is no definitive standard (e.g. PDO: mysql:host=localhost;dbname=example, Perl: DBI:mysql:database=$database;host=$hostname;port=$port).

Otherwise, I mainly just see Rails/Django defining DATABASE_URL.

[swalkinshaw]

Heroku and Doccu use DATABASE_URL. There's probably other hosts/infra related things which do as well.

[tristanbes]

I'm not in favor of changing DATABASE_URL to DB_URL

I would stick to DATABASE_URL since a lot of cloud providers are using this to expose their DSN. (Scalingo uses it, clever-cloud uses it and other international ones like @swalkinshaw reported).

PS: Frameworks also tends to use DATABASE_URL like for instance Symfony

[austinpray]

+1 for DATABASE_URL

[QWp6t]

lgtm @swalkinshaw

[swalkinshaw]

Thank you everyone

We also need the docs updated at https://github.com/roots/docs/blob/docs/bedrock/installing-bedrock.md if someone wants to help