Remove unnecessary static variables #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the autoloader is singeleton there is no reason to keep the static variables
|
Haven’t tested this yet but this is a good update 👍 |
|
Ditto 👍 |
|
@austinpray, @swalkinshaw Cheers guys! I was also thinking, shall I update all the variable names to follow PSR2? Just to be consistent with the code. |
|
Yeah good catch. Might as well 😄 |
|
@swalkinshaw this is done, could you please have a look? |
austinpray
approved these changes
Jun 9, 2019
There was a problem hiding this comment.
Tested by
"installer-paths": {
"web/app/mu-plugins/{$name}/": ["type:wordpress-muplugin", "roots/wp-stage-switcher"],
"web/app/plugins/{$name}/": ["type:wordpress-plugin"],
"web/app/themes/{$name}/": ["type:wordpress-theme"]
},
in composer.json
composer require roots/wp-stage-switcher
which nets me
composer remove roots/wp-stage-switcher
then revert the composer.json changes
composer require roots/wp-stage-switcher
LGTM
|
Thank you 👏 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the autoloader is singeleton there is no reason to keep the static variables