Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore debug.log #440

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Ignore debug.log #440

merged 2 commits into from
Jun 20, 2019

Conversation

pedropalau
Copy link
Contributor

This add debug.log file to .gitignore

@retlehs
Copy link
Sponsor Member

retlehs commented Jun 19, 2019

thanks for the PR! we don't define WP_DEBUG_LOG in bedrock, and when you define it you're allowed to define a specific location for the logfile..

not sure if this PR should be merged or not. seems like it would make sense if we defined WP_DEBUG_LOG w/o a path

@swalkinshaw
Copy link
Member

But the default is just define( 'WP_DEBUG_LOG', true ); which would result in this path. So it seems reasonable for Bedrock to ignore it?

@pedropalau
Copy link
Contributor Author

Yes, good point, in that case we don't need right now this modification until you defined WP_DEBUG_LOG w/o a path.

@pedropalau
Copy link
Contributor Author

pedropalau commented Jun 19, 2019 •
edited
Loading

But the default is just define( 'WP_DEBUG_LOG', true ); which would result in this path. So it seems reasonable for Bedrock to ignore it?

This is the case I have in the development stage.

I think we can ignore the debug.log file right now, until the WP_DEBUG_LOG is defined in Bedrock.

@aaemnnosttv
Copy link
Contributor

Why not ignore *.log ? I can't imagine someone would want to include a .log file in their repo but if they did, they could always whitelist it.

@austinpray
Copy link
Contributor

+1 to just ignoring *.log

I don’t see anything wrong with it and the community at large seems to be ok with it. Popular node gitignore has the same line: https://github.com/github/gitignore/blob/e58b3e0a015871e4caafd2eed04dc243ef5f30b4/Node.gitignore

@aaemnnosttv
Copy link
Contributor

WordPress ignore has it as well 😄

https://github.com/github/gitignore/blob/f9291de89f5f7dc0d3d87f9eb111b839f81d5dbc/WordPress.gitignore#L20-L23

@pedropalau
Copy link
Contributor Author

Yes, they ignore the debug.log file by default:

https://core.trac.wordpress.org/browser/branches/5.2/.gitignore#L54

@austinpray austinpray merged commit 2886d23 into roots:master Jun 20, 2019
gabrielwolf added a commit to gabrielwolf/bedrock-grunt-wordpress-deploy that referenced this pull request Jul 7, 2020
@gabrielwolf
Merge commit '6d8468140747f1e65f7b3c03e9cb2b17a88412be'
ff4fdd6 
* commit '6d8468140747f1e65f7b3c03e9cb2b17a88412be': (28 commits)
  Revert "Use inline phpcs rules instead of phpcs.xml"
  Editorconfig updates
  Use circleci in readme
  Use inline phpcs rules instead of phpcs.xml
  Better default composer options
  Update sponsors [ci skip]
  chore(readme): Use brand color for Twitter follow badge
  Update README [ci skip]
  Remove unused CircleCI executor
  Change to CircleCI
  Ignore debug.log (roots#440)
  Update CHANGELOG [ci skip]
  Bump roots/wordpress from 5.2.1 to 5.2.2
  Bump oscarotero/env from 1.1.0 to 1.2.0
  Remove Dependencies.io
  Bump vlucas/phpdotenv from 3.3.2 to 3.4.0
  Bump squizlabs/php_codesniffer from 3.4.0 to 3.4.2
  Use camelCase style for variable names
  Rename single static variable to instance
  Remove static variables
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pedropalau @retlehs @swalkinshaw @aaemnnosttv @austinpray