CircleCI: Use offical CircleCI PHP orb and next-gen docker images #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangrufus
force-pushed
the
circleci-update
branch
5 times, most recently
from
ec0e7c6
to
3711b62
Compare
tangrufus
force-pushed
the
circleci-update
branch
2 times, most recently
from
89fcab9
to
38c8ef3
Compare
tangrufus
force-pushed
the
circleci-update
branch
from
38c8ef3
to
563ede2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
matrixNotes
Dropped PHP 7.1 testing because of CircleCI-Public/cimg-php#1 (comment)
Yes. Let me know if we need it.
Benchmark
Not much difference actually.
Downloading the docker image, which ranging from 3 to 40 second depends whether the CircleCI instance has the docker layer cached, makes up the most of the build time.
With CircleCI pushing its new docker images forward, I expect the cache hit rate to go up in the coming months.