Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade oscarotero/env to ^2.0 #530

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Upgrade oscarotero/env to ^2.0 #530

merged 1 commit into from
Jun 12, 2020

Conversation

tangrufus
Copy link
Contributor

@tangrufus tangrufus commented Jun 11, 2020 •
edited
Loading

close #515
close #516

@tangrufus tangrufus marked this pull request as draft June 11, 2020 08:04
@tangrufus tangrufus marked this pull request as ready for review June 11, 2020 08:08
austinpray
austinpray approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@austinpray austinpray left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, LGTM!

Was following that PR to the env package: glad we he merged your PR! For posterity: oscarotero/env#7

@austinpray austinpray mentioned this pull request Jun 12, 2020
Closed
@tangrufus tangrufus merged commit ed4aeaf into roots:master Jun 12, 2020
@tangrufus tangrufus mentioned this pull request Jun 12, 2020
Closed
4 tasks
@tangrufus tangrufus mentioned this pull request Nov 16, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swalkinshaw swalkinshaw swalkinshaw approved these changes

@austinpray austinpray austinpray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

env function collide with illuminate/support
3 participants
@tangrufus @swalkinshaw @austinpray