Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MU plugin that disables two site health status tests 'conflicting' with bedrock #540

Closed
wants to merge 1 commit into from

Conversation

Levdbas
Copy link

@Levdbas Levdbas commented Jul 29, 2020

fixes

The PR removes the two Site Health Status notifications highlighted in red in the screenshot.

The code run by the theme_version check can be found here

This is my first PR attempt for a Roots project. So let me know if I missed something or something can be improved.

@Levdbas Levdbas changed the title add MU plugin that disables two conflicting site health status tests. add MU plugin that disables two site health status tests 'conflicting' with berock Jul 29, 2020
@Levdbas Levdbas changed the title add MU plugin that disables two site health status tests 'conflicting' with berock add MU plugin that disables two site health status tests 'conflicting' with bedrock Jul 29, 2020
@swalkinshaw
Copy link
Member

As another option, could we instead change the label and categorization of them? This is still probably a good solution, just wondering if it's better to leave them (so people know about their existence) but call out why they are "disabled".

@Levdbas
Copy link
Author

Levdbas commented Jul 29, 2020

I think this would've been nice, but unfortunately the site_status_tests hook only lets you add test or remove existing tests, see https://developer.wordpress.org/reference/hooks/site_status_tests/ for the documentation and some examples for this hook.

The only 'workaround' would be to remove these mentioned tests and add new ones specific for a Bedrock installation. Now that I am brainstorming about this idea: For example a test that checks the WP_ENV constant and warns if the site is not on a subdomain and still has the WP_ENV on staging.

There are possibilities but out of the scope of this PR. But might be a nice thing to consider for increasing the UX/DX.

@retlehs
Copy link
Sponsor Member

retlehs commented Feb 17, 2023

If you want to make a Composer package out of this I'd be happy to add it to our docs, but this isn't something we will be adding in Bedrock at this time

@retlehs retlehs closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants