Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump roots/wordpress-core-installer for composer 2 #552

Merged
merged 1 commit into from
Oct 25, 2020

Conversation

austinpray
Copy link
Contributor

@austinpray austinpray commented Oct 25, 2020

ref roots/wordpress-core-installer#4 (comment)

Screen Capture_select-area_20201025183002

changes

before

Screen Capture_select-area_20201025175907

Screen Capture_select-area_20201025180023

after

image

Screen Capture_select-area_20201025183725

notes for reviewer

Should be able to composer create roots/bedrock under both composer 1 and 2

Created project should boot an instance of WordPress just fine.

@austinpray
Copy link
Contributor Author

Using https://github.com/austinpray/bedrock-testbed

composer 1

image

image

composer 2

image

image

@austinpray austinpray merged commit 147a867 into master Oct 25, 2020
@swalkinshaw swalkinshaw deleted the austin-composer2-compat branch October 25, 2020 23:59
@KevinBerkhof KevinBerkhof mentioned this pull request Oct 28, 2020
4 tasks
@strarsis
Copy link

So only the composer lockfile has been updated? So packages were updated only in the existing version constraints?

@swalkinshaw
Copy link
Member

@strarsis correct

@austinpray
Copy link
Contributor Author

@strarsis our forked wordpress-composer-installer is backwards compatible with both composer 1 and 2. We tagged 1.100.0 which has support for composer 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants