Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] ts-bud incompatible with bud.typescript.typecheck #1480

Closed
4 of 5 tasks
kellymears opened this issue Jun 15, 2022 · 1 comment
Closed
4 of 5 tasks

[bug] ts-bud incompatible with bud.typescript.typecheck #1480

kellymears opened this issue Jun 15, 2022 · 1 comment
Assignees
@kellymears
Labels
bug Something isn't working @roots/bud-typescript

Comments

@kellymears
Copy link
Member

kellymears commented Jun 15, 2022 •
edited
Loading

Agreement

Expected Behavior

Typechecking should be applied to the build when enabled with:

bud.typescript.typecheck.enable()

Actual Behavior

The fork of the process from ForkTsCheckerWebpackPlugin:

  • invokes the bud cli usage instructions (visible in console)
  • quickly dies from exceeding the threshold set by typescript.memoryLimit

Increasing the memoryLimit value does nothing.

Steps To Reproduce

  1. use bud.config.mts syntax config
  2. add bud.typescript.typecheck.enable() to config
  3. run yarn ts-bud build

version

6.0.0

What package manager are you using?

yarn classic

version

1.22.18

Are you using pnpm?

  • yes
  • no

Additional information

This behavior is not present when using bud directly.

  • yarn bud build of a bud.config.cjs file is fine.
@kellymears kellymears added the bug Something isn't working label Jun 15, 2022
@kellymears kellymears self-assigned this Jun 15, 2022
@kellymears kellymears mentioned this issue Jun 20, 2022
Merged
kellymears added a commit that referenced this issue Jun 21, 2022
@kellymears
🐛 fix(patch): ts-bud incompatible with bud.typescript.typecheck [#1480]…
22a93c1 
… (#1492)

* 🔧 repo(none): set up workbench for 1480

* 🐛 fix(patch): dont use fork-ts-checker-webpack-plugin

* ✨ improve(patch): `@roots/bud-cache/invalidate-cache` extension
@kellymears
Copy link
Member Author

This should be fixed in 6.1.0, which will release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kellymears kellymears

Labels
bug Something isn't working @roots/bud-typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kellymears