Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] @roots/bud-imagemin extension not working as expected #1886

Closed
retlehs opened this issue Nov 17, 2022 · 1 comment · Fixed by #1888
Closed

[bug] @roots/bud-imagemin extension not working as expected #1886

retlehs opened this issue Nov 17, 2022 · 1 comment · Fixed by #1888
Labels
bug Something isn't working experimental @roots/bud-imagemin

Comments

@retlehs
Copy link
Sponsor Member

retlehs commented Nov 17, 2022 •
edited
Loading

Describe the issue

Setup a project based on https://bud.js.org/extensions/bud-imagemin/ and unable to get WebP assets generated
@retlehs retlehs added the bug Something isn't working label Nov 17, 2022
@kellymears kellymears mentioned this issue Nov 18, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #1888 Nov 19, 2022
kodiakhq bot pushed a commit that referenced this issue Nov 19, 2022
@kellymears
🩹 fix(patch): fix #1886 (#1888)
93e3d76 
- Fix: #1886
- Improve unit test: `sources/@roots/bud-imagemin/src/extension.test.ts`
- Add reproduction: `tests/reproductions/issue-1886`
- Add reproduction test: `tests/reproductions/issue-1886.test.ts`
- Docs: update documentation

refers:

- #1886 

## Type of change

**PATCH: backwards compatible change**



This PR includes breaking changes to the following core packages:

- none

This PR includes breaking changes to the follow extensions:

- none

## Dependencies

### Adds

- none

### Removes

- none
@kellymears kellymears mentioned this issue Nov 20, 2022
Merged
kodiakhq bot pushed a commit that referenced this issue Nov 20, 2022
@kellymears
📕 docs(none): @roots/bud-imagemin (#1892)
0062a06 
- Improve: `@roots/bud-imagemin` docs and README.md

refers:

- #1886 

## Type of change

**PATCH: backwards compatible change**



This PR includes breaking changes to the following core packages:

- none

This PR includes breaking changes to the follow extensions:

- none

## Dependencies

### Adds

- none

### Removes

- none
@kellymears
Copy link
Member

Fixed in 6.6.2 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working experimental @roots/bud-imagemin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🩹 fix(patch): fix #1886 roots/bud
2 participants
@retlehs @kellymears