Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: indicator/hmr errors #1248

Merged
merged 7 commits into from
Mar 22, 2022
Merged

fix: indicator/hmr errors #1248

merged 7 commits into from
Mar 22, 2022

Conversation

kellymears
Copy link
Member

@kellymears kellymears commented Mar 18, 2022

Overview

  • Fixes indicator error display
  • Fixes hot reload failures after syntax error
  • Changes default publicPath from auto to ''

refers: none
closes: none

Type of change

  • PATCH: bug fix

This PR includes breaking changes to the following core packages:

  • none

This PR includes breaking changes to the follow extensions:

  • none

Dependencies

I had to fork webpack hot middleware and update for Webpack 5 API in order to accomplish this.

I have another branch to clean up the code but it might take time. This has utility now.

Adds

  • none

Removes

  • none

@github-actions github-actions bot added @roots/bud-server dependencies Pull requests that update a dependency file labels Mar 18, 2022
@kellymears kellymears requested a review from retlehs March 18, 2022 14:19
@kellymears kellymears mentioned this pull request Mar 18, 2022
5 tasks
@github-actions github-actions bot added the test label Mar 21, 2022
@kellymears kellymears merged commit c6a50b6 into main Mar 22, 2022
@kellymears kellymears deleted the fork-whm branch March 22, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants