🩹 fix(@roots/sage): serve options including hostname #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where calling
bud.servewith a full hostname (fully qualifiedURLorstring; rather than an interface or a port) would cause hot assets to 500. this is due to an acorn implementation detail that is no longer needed, but it is easy to sidestep from the bud.js end by just removing the proxy request handler entirely and letting http-party do its thing.refers:
Type of change
PATCH: backwards compatible change
This PR includes breaking changes to the following core packages:
This PR includes breaking changes to the follow extensions:
Dependencies
Adds
Removes