-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bud install conflicts #779
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
- adds sync filter: `'config.override'` (`build` namespace is reserved for compiler) - modifies`bud.config` to pass built config to `bud.hook.on('config.override')` event. - this happens directly before `bud.build` verifies the configuration (strips `undefined` and `null` values) - `bud.override` is just an alias for `bud.config`. - fix: `hooks.filter` and `hooks.promised` will now tap the function passed to them if the supplied value is a `CallableFunction` type
Co-authored-by: Renovate Bot <bot@renovateapp.com>
This was referenced Dec 19, 2021
Closed
3 tasks
closed in favor of #886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI
Continuous integration issue.
dependencies
Pull requests that update a dependency file
dev
examples
@roots/bud
@roots/bud-api
@roots/bud-babel
@roots/bud-build
@roots/bud-compiler
@roots/bud-dashboard
@roots/bud-eslint
@roots/bud-extensions
@roots/bud-framework
@roots/bud-hooks
@roots/bud-postcss
@roots/bud-preset-recommend
@roots/bud-preset-wordpress
@roots/bud-sass
@roots/bud-support
@roots/bud-tailwindcss
@roots/bud-typescript
@roots/sage
test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should absolutely not be merged until after 5.0.0 is released and we have space to do
next
builds that aren't majorly disruptive to peoples workflows.Problem
bud's handling of transitive dependencies is insufficient to deal with bud extensions that rely on other extensions (see sage -> wordpress-preset -> react -> babel)
this is the primary cause of issues like #567, #730. actually, installs work fine if you are installing a root level extension (like babel, sass). it is only when installing presets and the like that the problems come to the fore.
Rundown
Changelog
$ bud install
(and other commands) displaying a loading spinner and "compiling" message during runrefs: #567, #730