New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move assets found in node_modules/ to dist/vendor; simpler assets/config.json #1697

Merged

retlehs merged 1 commit into roots:sage-9 from ptrckvzn:sage-9-nodemodulesassets

Aug 26, 2016

ptrckvzn commented Aug 26, 2016

This PR addresses the issues here : #1694

Added a new file-loader for assets in node_modules. The loaders moves fonts and images to dist/vendor/... and not _/node_modules/.../...
Put back [path] in other loaders to respect the subfolder tree in assets/images and assets/fonts
Removed hash on images file name to be able to load them with App\asset_path
Removed config vars that should not be changed (assets path, dist path)


          move assets found in node_modules/ to dist/vendor; simpler assets/con…

42061ad

…fig.json

retlehs merged commit 97c1a30 into roots:sage-9

ptrckvzn pushed a commit to ptrckvzn/sage that referenced this pull request


          Merge remote-tracking branch 'upstream/sage-9' into sage-9-public-path

33578d0

* upstream/sage-9:
  move assets found in node_modules/ to dist/vendor; simpler assets/config.json (roots#1697)

# Conflicts:
#	assets/config.json

ptrckvzn deleted the sage-9-nodemodulesassets branch

August 26, 2016 17:46

ptrckvzn mentioned this pull request

Images are put in fonts dir after build #1694

Closed

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment