Bootstrap 4 alpha 6 dependency update, error recovery for gulp. #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uring `gulp watch`. Thanks, Nicolo_Sacchi and epiphron!
|
@retlehs sorry for the doubled PR. I managed to delete my own 8.5.0 branch which closed the previous PR. Not my finest moment. |
|
Thanks! 👍 I have two commits I'd like to add to this PR though;
Should I do a separate PR with those commits? Or will you add them as a patch to this PR? |
|
I just realized that Sage 8 only requires Node 4.x and that I set the I know it's a minor detail but I went ahead and created a PR for it anyway (#1831) |
|
This PR has been inactive for a while so I went ahead and made an updated PR with the error handling fix and the Bootstrap dependency bump (#1832). Hope everyone is okay with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at this PR after a bad push ate my 8.5.0 branch. See here for the error recovery code (thanks to Nicolo_Sacchi and epiphron!). I didn't write it, I just turned it into a PR.