Fix gulp imagemin options #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image minification options (specifically SVG plugin options) were not working when using the latest version of gulp-imagemin due to a new options passing structure, see: https://github.com/sindresorhus/gulp-imagemin/releases/tag/v3.0.0
|
thanks! |
asuh
added a commit
to asuh/sage-starter
that referenced
this pull request
Feb 22, 2017
Latest version of gulp-imagemin breaks with old method roots/sage#1839
smutek
pushed a commit
to ainsleyagency/sage842
that referenced
this pull request
Mar 7, 2017
Update dependencies to bring theme up to date with Sage 8.5 (minus Bootstrap 4). Should enable use of Node versions >= v6 and eliminate issues with deployments via deploybot * Update gulp-imagemin options * ([roots#1839](roots#1839)) * Add error handling to `scripts` and `styles` gulp tasks * ([roots#1832](roots#1832)) * Update dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image minification options (specifically SVG plugin options) were not
working when using the latest version of gulp-imagemin due to a new
options passing structure, see:
https://github.com/sindresorhus/gulp-imagemin/releases/tag/v3.0.0