New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Webpack 5 / fix issues #2607
Merged
Merged
Changes from 23 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
1c90578
Update webpack from v3 to v5.
strarsis d6fae85
Change hash to fullhash (deprecation).
strarsis 0fa3214
Fix BrowserSync.
strarsis b2b7349
Fix postcss peer dependency.
strarsis 7e56fba
Fix lint error.
strarsis 373a8d9
Update webpack.config.js
strarsis ec5d593
Bump node engine version.
strarsis 7ba589f
Remove incompatible dependency (friendly-errors-webpack-plugin).
strarsis 28d205c
Re-add friendly-errors-webpack-plugin dependency (from fixed PR for n…
strarsis b65273f
Use webpack5 PR repository for sage-lib (PR branch testing).
strarsis e795356
Replace deprecated [hash:8]
strarsis 7fac5fb
Move buble to devDependencies.
strarsis 8e33cb3
Update CHANGELOG.md
strarsis acc041d
Remove `:8` hash postfix.
strarsis 8bab69f
Merge branch 'webpack5' of https://github.com/strarsis/sage into webp…
strarsis bef8232
Replace copy plugin with maintained, contrib one.
strarsis 2904cdd
Update yarn lockfile.
strarsis 1d747a8
Update yarn lockfile.
strarsis 67ce1d0
Use [contenthash] instead of [fullhash] to get around webpack 5 issue…
strarsis 11e4827
Enable `contextRelativeKeys` so emitted assets also have context-rela…
strarsis 4e0996b
Add note about slightly new path resolve behavior.
strarsis dfe5c5d
Fix Sage release version (current in master is v9.0.10).
strarsis b61ecc4
Use higher version bump for new release version (9.1).
strarsis 37c0005
Update copy-webpack-plugin to v8.0.0 (including config adjustments).
strarsis 480976b
Fix indents.
strarsis 0db81ca
Update stylelint-config-standard to latest release.
strarsis 7cc577c
Update dev dependencies.
strarsis 83175ab
Update node versions in travis.
strarsis 5683e22
Update PHP versions in travis.
strarsis c3e964c
Update dev dependency.
strarsis 57891a4
Update sage-installer (dev).
strarsis 4bd6861
Update sage-installer (dev).
strarsis 848bc0b
Add filp/whoops dev dependency for Sage 10-like PHP error handling.
strarsis 5499e5e
Re-add Friendly-errors-webpack-plugin (fork).
strarsis c303bab
Update build dependencies.
strarsis 6d40a61
Use Soil 4.x theme support, as in Sage 10.
strarsis fde0c7f
Cosmetic code change.
strarsis 760524e
Update dependencies (sass).
strarsis 8966bfa
Fix PHPCS lint error.
strarsis f079e27
Re-update lockfile.
strarsis File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is breaking, but clearly, we can’t call this v10.0.0. Just one of those times we're not quite SemVer 🤷🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth trying to restore the previous path resolving behavior? Not sure if this had been a bug with the earlier webpack components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new behavior makes much more sense, and is simpler, but if we want to avoid this being a breaking change, yeah, restoring the previous behavior is needed.