Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Download dwca zip file as binary #17

Merged
merged 1 commit into from
Jul 1, 2017
Merged

Download dwca zip file as binary #17

merged 1 commit into from
Jul 1, 2017

Conversation

gustavobio
Copy link
Contributor

Description

Changed mode = "wb" in a call to download.file in order for this to work on Windows. Without the fix unzip fails.

@codecov-io
Copy link

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   59.52%   59.52%           
=======================================
  Files           6        6           
  Lines         252      252           
=======================================
  Hits          150      150           
  Misses        102      102
Impacted Files Coverage Δ
R/dwca.R 80.8% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a043730...c434e64. Read the comment docs.

@sckott
Copy link
Contributor

sckott commented Jul 1, 2017

thanks @gustavobio ! LGTM

@sckott sckott merged commit dda94a9 into ropensci-archive:master Jul 1, 2017
@sckott sckott added this to the v0.2 milestone Jul 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants