Feedback CRAN

[richelbilderbeek]

Unknown, possibly mis-spelled, fields in DESCRIPTION:
'Remotes'

Please omit this field.

Please single qupte software names such as 'BEAST2' in your Description and give web references in > the form yhttp.....> ifthese are not R packages.

Best,
Uwe Ligges

[richelbilderbeek]

• Remove remotes. OK, can be (unexpectedly) safely omitted
• Put quotes around software names. OK
• Replace https by http. I think this is incorrect. GitHub has https://as a web address

[richelbilderbeek]

Sent the package again.

[richelbilderbeek]

By the way, we also found files
-rw-r--r-- 1 hornik hornik 6930 Mar 19 09:57 created.xml
-rw-r--r-- 1 hornik hornik 6930 Mar 19 09:57 expected.xml

and then

$ grep -r expected.xml beautier
beautier/R/compare_lines.R: writeLines(text = expected, "~/expected.xml")

You shoudl not write files to the user filspace without explicit user agreement e.g. by enering a filename.

In this case, you could, e.g., use the session dir given by tempdir() to create temporary files.

Although it was just an internal function, only used in debugging, sure I fixed it :-)

[richelbilderbeek]

Submitted again...

[richelbilderbeek]

Thanks, please write one or two sentensences about the functionality of 'BEAUti' and 'BEAST2'.

Please add an URL for 'BEAUti' and 'BEAST2' in your description text in the form
http:... or https:...
with angle brackets for auto-linking and no space after 'http:' and 'https:'.

Please fix and resubmit.

Best,
Swetlana Herbrandt

[richelbilderbeek]

Done, submitted again

[richelbilderbeek]

Re: CRAN submission beautier 1.13

30 March 2018 15:59 8 KB
From:
Uwe Ligges
To:
cran-submissions@r-project.org, Swetlana Herbrandt (1 more)

Well, and again


New things in home:
created.xml
expected.xml

So we had to archive the package again.

No idea why you cannot fix <your package appropriately.

Please do not submit again until you know what you are doing.

Uwe Ligges

[richelbilderbeek]

Hmm, before a n earlier comment, these files were created with a hardcoded path (it was for debugging only). Now, the created.xml and other filename are determined by the user.

I removed all calls to compare_lines and I let the compare_lines test use temporary files.

[richelbilderbeek]

[CRAN-pretest-inspect] CRAN submission beautier 1.14.1

29 October 2018 09:41 7 KB
From:
[...]
To:
[...]
Cc:
[...]

Dear maintainer,

package beautier_1.14.1.tar.gz has been auto-processed and is pending a manual inspection. A CRAN team member will typically respond to you within the next 5 working days. For technical reasons you may receive a second copy of this message when a team member triggers a new check.

Log dir: <https://win-builder.r-project.org/incoming_pretest/beautier_1.14.1_20181029_092512/>
The files will be removed after roughly 7 days.
Installation time in seconds: 21
Check time in seconds: 151
R Under development (unstable) (2018-10-27 r75507)

Pretests results:
Windows: <https://win-builder.r-project.org/incoming_pretest/beautier_1.14.1_20181029_092512/Windows/00check.log>
Status: 1 NOTE
Debian: <https://win-builder.r-project.org/incoming_pretest/beautier_1.14.1_20181029_092512/Debian/00check.log>
Status: 1 NOTE

Last released version's CRAN status: OK: 1
See: <https://CRAN.R-project.org/web/checks/check_results_beautier.html>

CRAN Web: <https://cran.r-project.org/package=beautier>

No strong reverse dependencies to be checked.

Best regards,
CRAN teams' auto-check service
Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-ix86+x86_64
Check: CRAN incoming feasibility, Result: NOTE
Maintainer: 'Richel J.C. Bilderbeek [...]'

New submission

Package was archived on CRAN

CRAN repository db overrides:
X-CRAN-Comment: Archived on 2018-03-28 for policy violation.

Checking creates {created,expected}.xml in home.

[richelbilderbeek]

Uwe Ligges is sharp and right again:

Re: CRAN submission beautier 1.14.1

2 November 2018 19:20 9 KB
From:
Uwe Ligges
To:
Richel J.C. Bilderbeek, CRAN

[...]

Well, you may create tmepfiles, but in the tempdir() please, not in the user filespace.

Also note we see examples such as

}
\examples{
created <- get_alignment_id("/home/homer/anthus_aco_sub.fas")
expected <- "anthus_aco_sub"
testit::assert(created == expected)
}


but "/home/homer/anthus_aco_sub.fas" won't exist on a users machine, ence should be replaced appropriately.

Best,
Uwe Ligges

Sent a Feature Request to MangoTheCat about checking for this, which will trickle in.

[richelbilderbeek]

Yay, accepted by rOpenSci!

[richelbilderbeek]

Done!