Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommended scaffolding for spatial packages #362

Merged
merged 7 commits into from
Nov 19, 2021
Merged

Recommended scaffolding for spatial packages #362

merged 7 commits into from
Nov 19, 2021

Conversation

mpadge
Copy link
Member

@mpadge mpadge commented Nov 19, 2021

@mpadge mpadge requested a review from maelle November 19, 2021 10:25
maelle
maelle requested changes Nov 19, 2021
View reviewed changes
Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, so cool to see a clear recommendation! Could you please also update the changelog?

pkg_building.Rmd Outdated Show resolved Hide resolved
@mpadge mpadge requested a review from maelle November 19, 2021 12:30
maelle
maelle approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

@maelle maelle merged commit 6f00fd2 into ropensci:dev Nov 19, 2021
@mpadge
Copy link
Member Author

mpadge commented Nov 19, 2021

Always a pleasure!! 😄

@maelle maelle mentioned this pull request Jan 4, 2022
Closed
@maelle maelle added this to the 0.8.0 milestone Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelle maelle maelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpadge @maelle