Fix queries with multiple features and more than one osm_types

[jmaspons]

Example of the error for osm_types and features with non-multiple lengths

q <- opq("Catalunya") |> 
    add_osm_features(features = c("\"amenity\"=\"school\"",
                                  "\"amenity\"=\"kindergarten\"",
                                  "\"amenity\"=\"music_school\"",
                                  "\"amenity\"=\"language_school\"",
                                  "\"amenity\"=\"dancing_school\""))
opq_string(q)
#> Error in sprintf("  %s %s (%s);\n", opq$osm_types, features, opq$bbox) :
#>  arguments cannot be recycled to the same length

For osm_types and features with multiple lengths, every feature gets only one osm_type instead of all osm_types

q <- opq("Catalunya") |> 
    add_osm_features(features = c("\"amenity\"=\"school\"",
                              "\"amenity\"=\"kindergarten\"",
                              "\"amenity\"=\"music_school\""))
cat(opq_string(q))
#> [out:xml][timeout:25];
#> (
#>   node ["amenity"="school"] (40.5229822,0.1594133,42.8615226,3.3222508);
#>   way ["amenity"="kindergarten"] (40.5229822,0.1594133,42.8615226,3.3222508);
#>   relation ["amenity"="music_school"] (40.5229822,0.1594133,42.8615226,3.3222508);
#> );
#> (._;>;);
#> out body;

[mpadge]

That's great. Could you maybe just add a test to illustrate the effect that this has? A suggestion would be in the osm_types test after this line:

osmdata/tests/testthat/test-opq.R

Line 122 in 08908c7

expect_true ("nwr" == q1$osm_types)

something like this (with the actual getbb() call from opq() switched off, of course):

features <- c(
    "\"amenity\"=\"school\"",
    "\"amenity\"=\"kindergarten\"",
    "\"amenity\"=\"music_school\"",
    "\"amenity\"=\"language_school\"",
    "\"amenity\"=\"dancing_school\""
)
q <- opq("Catalunya") |> 
    add_osm_features(features = features)
s <- opq_string(q)

n_fts <- length (features)
n_fts_in_query <- length (gregexpr ("amenity", s) [[1]])
# Query should have that number repeated for each of (node, way, relation):
expect_equal (n_fts_in_query, n_fts * 3L)

[jmaspons]

Tests added and NEWS updated

[mpadge]

Great, thanks!