Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function to download data #4

Closed
sckott opened this issue Sep 3, 2014 · 10 comments
Closed

Function to download data #4

sckott opened this issue Sep 3, 2014 · 10 comments
Assignees

Comments

@sckott
Copy link
Contributor

sckott commented Sep 3, 2014

This isn't part of the OAI process

We need to get links to data files from other functions...then download data, should be in a zip file

@naupaka naupaka self-assigned this Sep 3, 2014
@naupaka
Copy link
Member

naupaka commented Sep 3, 2014

Hey @gavinsimpson thanks for your help! I'm still actively working on this and did a bunch of the roxygen cleaning already - was a bit chaotic on the first commit, for sure.

@gavinsimpson
Copy link
Contributor

Sorry @naupaka I didn't realise provenance; was just trying to clean-up stuff so I could get a build working locally

@gavinsimpson
Copy link
Contributor

@naupaka Have you got something to push? The library() calls are causing R CMD check to error out and the missing roxygen tags make it impossible to build any new documentation making it impossible to work on other functions cleanly.

@sckott
Copy link
Contributor Author

sckott commented Sep 4, 2014

passing now...

sckott added a commit that referenced this issue Oct 28, 2014
sckott added a commit that referenced this issue Oct 28, 2014
@sckott
Copy link
Contributor Author

sckott commented Oct 28, 2014

I reworked this function, see function pg_data(). Because files can be large, the function now writes to disk and caches files, so subsequent calls of the same dataset don't have to get it from the web again, unless the files are deleted. And handles a set of files from a DOI and single files from a DOI

@naupaka
Copy link
Member

naupaka commented Oct 28, 2014

Much nicer this way!

@sckott
Copy link
Contributor Author

sckott commented Oct 28, 2014

cool cool cool

@karawoo
Copy link
Contributor

karawoo commented Oct 28, 2014

😸

@sckott
Copy link
Contributor Author

sckott commented Oct 28, 2014

🐻

sckott added a commit that referenced this issue Oct 28, 2014
@sckott
Copy link
Contributor Author

sckott commented Oct 28, 2014

think this is working good now, we can open new issues if anything is broken

@sckott sckott closed this as completed Oct 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants