Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch documents to unique ptr #50

Merged
merged 3 commits into from
Jan 15, 2019
Merged

Switch documents to unique ptr #50

merged 3 commits into from
Jan 15, 2019

Conversation

jeroen
Copy link
Member

@jeroen jeroen commented Dec 17, 2018

This seems to break the poppler-data hack but I don't know why.

@jeroen
Copy link
Member Author

jeroen commented Dec 30, 2018

I think it happens because poppler resets the GlobalParams when the document-count goes to 0.

@codecov-io
Copy link

Codecov Report

Merging #50 into master will decrease coverage by 0.02%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #50      +/-   ##
=========================================
- Coverage   46.92%   46.9%   -0.03%     
=========================================
  Files           4       4              
  Lines         309     307       -2     
=========================================
- Hits          145     144       -1     
+ Misses        164     163       -1
Impacted Files Coverage Δ
src/bindings.cpp 47.52% <61.53%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b22fef...5790ec8. Read the comment docs.

@jeroen jeroen merged commit a1eec29 into master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants