Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R-universe interviews Finale blog post #629

Merged
merged 35 commits into from Nov 6, 2023
Merged

R-universe interviews Finale blog post #629

merged 35 commits into from Nov 6, 2023

Conversation

yabellini
Copy link
Contributor

Spanish draft
English skeleton

@yabellini yabellini marked this pull request as ready for review September 12, 2023 18:18
@yabellini
Copy link
Contributor Author

@jeroen this is a blog post to close the first series of interviews about r-universe, do you want to review? The idea is to publish after the last one that we will post this Friday.

Then @steffilazerte I will request your final review before publish it.

@steffilazerte steffilazerte added the blog post Blog posts to be published when merged label Sep 15, 2023
@jeroen jeroen force-pushed the main branch 2 times, most recently from c4aa876 to 26d7449 Compare October 13, 2023 14:22
@jeroen jeroen force-pushed the main branch 2 times, most recently from ae9e9e4 to 3764b0a Compare October 30, 2023 13:41
@yabellini
Copy link
Contributor Author

Hey @jeroen I will go ahead with this article, so we can publish next week. I think it looks good. Please, @steffilazerte can you review ? Thanks so much!!!

@jeroen
Copy link
Member

jeroen commented Nov 2, 2023

Thanks! Sorry for taking so long to look at it 🙈

It looks good! I made some small fixes to the images, and fixed the links on the english version of the post to link to English interviews.

steffilazerte
steffilazerte reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@steffilazerte steffilazerte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yabellini,
What a lovely summary! It was really cool to see how they all fit together and showcased different aspects of the R-Universe. I think I first I was thinking, "Oh yes, just a quick reminder", but when I saw it all together, I had a totally different perspective.

My comments are mostly technical. I did add the project names to the summaries that didn't have the name in the title of the post, so that in each summary it's clear who was interviewed (or what project, at least).

Also, I realized that I don't think the Alt text works with the carousel. I'll open an issue regarding that.

  • post follows Content Guidelines
  • post follows Style Guide
  • title is in Title Case
  • publication date is ok -> Always a reminder, just in case 😉
  • alternative text of images is informative
  • author metadata is provided with correct folder name
  • html not included in pull request of Rmd post
  • I ran roblog::ro_lint_md() on index.md
  • I ran roblog::ro_check_urls() on index.md
  • I ran a spell-check on index.md
  • YAML subject tags are ok ("tech notes" for tech notes; "community" for non-staff non-editor)
  • YAML field 'preface' is present if necessary

content/blog/2023-10-01-r-universe-interviews/index.en.md Outdated Show resolved Hide resolved
content/blog/2023-10-01-r-universe-interviews/index.en.md Outdated Show resolved Hide resolved
content/blog/2023-10-01-r-universe-interviews/index.en.md Outdated Show resolved Hide resolved
content/blog/2023-10-01-r-universe-interviews/index.en.md Outdated Show resolved Hide resolved
content/blog/2023-10-01-r-universe-interviews/index.en.md Outdated Show resolved Hide resolved
content/blog/2023-10-01-r-universe-interviews/index.en.md Outdated Show resolved Hide resolved
content/blog/2023-10-01-r-universe-interviews/index.en.md Outdated Show resolved Hide resolved
content/blog/2023-10-01-r-universe-interviews/index.es.md Outdated Show resolved Hide resolved
content/blog/2023-10-01-r-universe-interviews/index.en.md Outdated Show resolved Hide resolved
content/blog/2023-10-01-r-universe-interviews/index.en.md Outdated
author:
- Alejandra Bellini
- Yanina Bellini Saibene
date: '2023-10-01'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update here and in the name of the folder 😁

@yabellini @steffilazerte
Apply suggestions from review English text
8a48440 
Co-authored-by: Steffi LaZerte <steffi@steffi.ca>
yabellini and others added 2 commits November 2, 2023 16:50
@yabellini
Copy link
Contributor Author

Thanks @jeroen and @steffilazerte I will modify the publication date for next Monday. :-)

@yabellini yabellini merged commit 4f330b2 into main Nov 6, 2023
4 checks passed
@yabellini yabellini deleted the r-universe-interviews branch November 6, 2023 16:20
jeroen added a commit that referenced this pull request Nov 9, 2023
@yabellini @steffilazerte @jeroen
R-universe interviews Finale blog post (#629)
1fffc52 
Co-authored-by: Steffi LaZerte <steffi@steffi.ca>
Co-authored-by: Jeroen Ooms <jeroenooms@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffilazerte steffilazerte steffilazerte left review comments

Assignees
No one assigned
Labels
blog post Blog posts to be published when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yabellini @jeroen @steffilazerte