Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing topic to pkgdown config #156

Merged
merged 1 commit into from
Jul 22, 2024
Merged

docs: add missing topic to pkgdown config #156

merged 1 commit into from
Jul 22, 2024

Conversation

maelle
Copy link
Member

@maelle maelle commented Jul 18, 2024

but maybe you'll prefer using the concept. this counts as "bug report" in any case. 😸 https://ropensci.r-universe.dev/builds

@florianm
Copy link
Collaborator

Hi @maelle - thanks for the PR!

I'm working on a separate branch to add support for all entity endpoints. That branch also will migrate to the new test server. I'll merge your PR here and will make sure I've got it backported to my PR as well.

Copy link
Collaborator

@florianm florianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving these changes, LGTM. PR #155 will add more entity management entries. In the meantime, this PR will hopefully fix the pkgdown build error.

@florianm florianm merged commit 88f3a81 into main Jul 22, 2024
3 of 4 checks passed
@florianm florianm deleted the maelle-patch-1 branch July 22, 2024 02:24
@florianm
Copy link
Collaborator

It turned out that entitylist_update used an outdated @family dataset-management. I'm updating this to entity-management in #155.

florianm added a commit that referenced this pull request Jul 23, 2024
* Fix #156: entitylist_update family changed to entity-management
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants