Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to master #602

Merged
merged 30 commits into from
Jul 5, 2020
Merged

Develop to master #602

merged 30 commits into from
Jul 5, 2020

Conversation

elinw
Copy link
Collaborator

@elinw elinw commented Jul 5, 2020

No description provided.

kylebutts and others added 26 commits March 1, 2020 22:55
Few changes:
1. Since sf objects have class = "sfc_GEOMETRYTYPE" "sfc", we can define sfl for "sfc" that will be called if there does not exist and sfl for "sfc_GEOMETRYTYPE".

2. I made the example a bit more relevant for sf objects, namely summarizing the CRS (projection) being used. I do think that sf objects should be used as an included sfl, but that could be because I spend a lot of time working with spatial objects ;). 

3. There is mention of skim_by_type.sfc_MULTIPOLYGON, which I don't think needs to be in here unless I misunderstand skimr's code. The "skim_with" factory should already use the base sfl's for numeric, factors, characters, etc. and as you can see the skim_sf() works automatically without the skim_by_type function.
fix whitespace count and add test
Since knitr v1.29, knitr::kable() will add the table caption if provided
Update tests to allow older versions of knitr and add news
Add support for lubridate Timspan class because it is S4 and does not…
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2020

Codecov Report

Merging #602 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   96.31%   96.32%           
=======================================
  Files          13       13           
  Lines         597      598    +1     
=======================================
+ Hits          575      576    +1     
  Misses         22       22           
Impacted Files Coverage Δ
R/get_skimmers.R 100.00% <100.00%> (ø)
R/stats.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e2ade...18fa326. Read the comment docs.

@elinw elinw merged commit db89820 into master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants