Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verbose argument to download_smap() #44

Closed
mbjoseph opened this issue Jul 24, 2018 · 0 comments
Closed

Add verbose argument to download_smap() #44

mbjoseph opened this issue Jul 24, 2018 · 0 comments
Assignees
@mbjoseph
Labels
enhancement

Comments

@mbjoseph
Copy link
Member

@ldecicco-USGS suggests adding some message that indicates when files are downloading so users know that things are happening (ropensci/software-review#231). This will be particularly useful if people are downloading many large files over a slow connection.

The easiest way to do this would be to add a verbose argument to download_smap that optionally prints which files are being downloaded when.
@mbjoseph mbjoseph self-assigned this Jul 24, 2018
mbjoseph added a commit that referenced this issue Jul 24, 2018
@mbjoseph
Adding verbose argument to download_smap()
3b68bf5 
This adds an argument to download_smap() that prints which files
are being downloaded, to reassure users that things are really
happening.

Also, this includes an unrelated improvement to the documentation
for find_smap() that points users to the "Details" section for a
list of data set ids that are supported by smapr.

Solves #44
@mbjoseph mbjoseph mentioned this issue Jul 24, 2018
Merged
@mbjoseph mbjoseph mentioned this issue Aug 1, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbjoseph mbjoseph

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbjoseph